refactor(ingest): Minor cleanup of File, CsvEnricher, BusinessGlossary, and FileLineage sources #7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, and FileLineage sources
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Mar 30, 2023
| @@ -102,6 +103,9 @@ class CSVEnricherSource(Source): | |||
| be applied at the entity field. If a subresource IS populated (as it is for the second and third rows), glossary | |||
| terms and tags will be applied on the subresource. Every row MUST have a resource. Also note that owners can only | |||
| be applied at the resource level and will be ignored if populated for a row with a subresource. | |||
|
|
|||
| :::note | |||
| This source will not work on very large csv files that do not fit in memory. | |||
There was a problem hiding this comment.
i think you need a trailing ::: as well
| T = TypeVar("T", bound=WorkUnit) | ||
|
|
||
|
|
||
| def auto_workunit_reporter(report: SourceReport, stream: Iterable[T]) -> Iterable[T]: |
There was a problem hiding this comment.
I would love to get to a point where sources can also generate MCPs and MCEs directly, and the helper wraps them into WorkUnits as necessary
yoonhyejin
pushed a commit
that referenced
this pull request
Apr 3, 2023
…y, and FileLineage sources (#7718) - Adds auto_workunit_reporter to each source - Standardizes comments around remote paths - Adds back AuditStamp to FileLineage source - Some generic refactoring
hsheth2
added a commit
to hsheth2/datahub
that referenced
this pull request
Apr 4, 2023
Fixes a regression from datahub-project#7718.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few followups to #7552, + some modernization of the sources, with
auto_workunit_reporter.Refactoring got the most complicated on the file lineage source but logic should still be the same, sorry if it's a difficult review.
Checklist