Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): fix lint in looker #7695

Merged
merged 1 commit into from
Mar 27, 2023
Merged

chore(lint): fix lint in looker #7695

merged 1 commit into from
Mar 27, 2023

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 27, 2023
mayurinehate
mayurinehate approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

treff7es
treff7es approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @anshbansal

@treff7es treff7es merged commit a62889b into master Mar 27, 2023
@treff7es treff7es deleted the aseem-fix-lint branch March 27, 2023 12:08
gmcgoldrick-r7 pushed a commit to rapid7/datahub that referenced this pull request Mar 27, 2023
@anshbansal @gmcgoldrick-r7
chore(lint): fix lint in looker (datahub-project#7695)
a49c12b
yoonhyejin pushed a commit that referenced this pull request Apr 3, 2023
@anshbansal
chore(lint): fix lint in looker (#7695)
45e7a33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@mayurinehate mayurinehate mayurinehate approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @treff7es @mayurinehate