Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/bigquery): quote string constants in query #7694

Merged

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Mar 27, 2023

Quotes accidentally removed in this PR.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -24.06 ⚠️

Comparison is base (a62889b) 74.89% compared to head (8df1dcf) 50.83%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7694       +/-   ##
===========================================
- Coverage   74.89%   50.83%   -24.06%     
===========================================
  Files         353      353               
  Lines       35379    35379               
===========================================
- Hits        26497    17986     -8511     
- Misses       8882    17393     +8511     
Flag Coverage Δ
pytest-testIntegration 50.83% <ø> (-0.01%) ⬇️
pytest-testIntegrationBatch1 ?
pytest-testQuick ?
pytest-testSlowIntegration ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ub/ingestion/source/bigquery_v2/bigquery_schema.py 63.08% <ø> (-3.36%) ⬇️

... and 199 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hsheth2 hsheth2 merged commit 279f38a into datahub-project:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants