chore(ui): change background color to transparent for avatar with photoUrl #7527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like linting is failing! Do you mind checking? |
hieunt-itfoss
force-pushed
the
remove-background-color-for-avatar-with-photo-url
branch
from
5bbe479 to
4058533
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…r-avatar-with-photo-url
Sorry for the late response. I just update this PR. The linting is fixed. |
|
Before: After removing background: |
|
Can you post another set of screenshots confirming that for Avatars without a photo, this works as expected? |
avatarWithDefault: |
chriscollins3456
approved these changes
Apr 20, 2023
iprentic
pushed a commit
that referenced
this pull request
Apr 27, 2023
…toUrl (#7527) Co-authored-by: Nguyen Tri Hieu <[email protected]> Co-authored-by: Chris Collins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7145
transparentprops if the avatar doesn't have background-color which is interpolated ingetAvatarColor.Checklist