fix(ingest): Do not require platform_instance for stateful ingestion #7397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the changes from #6795, I believe that
get_platform_instance_id
can now returnNone
. See its only usage:In
StatefulIngestionSourceBase._get_last_checkpoint
Note that in that PR,
get_latest_checkpoint
was configured to accept an optionalplatform_instance_id
(and also note that in the not implemented case,None
is implicitly passed?)Since we still want to keep implementations of
get_platform_instance_id
for backwards compatibility, I allow it to returnNone
for when you sometimes have a platform_instance, and other times don't, like with Kafka.Also removes any validation around null
platform_instance
that I could find.EDIT: Tested the following recipe
Checklist