Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/unity): simplify MCP generation and reporting #6911

Merged
merged 4 commits into from
Jan 5, 2023
Merged

fix(ingest/unity): simplify MCP generation and reporting #6911

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
877a73e
start unity source cleanup
hsheth2 Dec 30, 2022
3033c12
more simplification
hsheth2 Dec 30, 2022
4c8fa1b
Merge branch 'master' into unity-cleanup
jjoyce0510 Jan 3, 2023
62dfbd6
Merge branch 'master' into unity-cleanup
hsheth2 Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion metadata-ingestion/src/datahub/emitter/mcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import dataclasses
import json
from typing import TYPE_CHECKING, Optional, Tuple, Union
from typing import TYPE_CHECKING, List, Optional, Tuple, Union

from datahub.emitter.aspect import ASPECT_MAP, TIMESERIES_ASPECT_MAP
from datahub.emitter.serialization_helper import post_json_transform, pre_json_transform
Expand Down Expand Up @@ -99,6 +99,12 @@ def __post_init__(self) -> None:
f"aspectName {self.aspectName} does not match aspect type {type(self.aspect)} with name {self.aspect.get_aspect_name()}"
)

@classmethod
def construct_many(
cls, entityUrn: str, aspects: List[Optional[_Aspect]]
) -> List["MetadataChangeProposalWrapper"]:
return [cls(entityUrn=entityUrn, aspect=aspect) for aspect in aspects if aspect]

def make_mcp(self) -> MetadataChangeProposalClass:
serializedEntityKeyAspect: Union[None, GenericAspectClass] = None
if isinstance(self.entityKeyAspect, DictWrapper):
Expand Down
Loading