Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/powerbi-report-server): deprecate unused graphql config #6630

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix(ingest/powerbi-report-server): deprecate unused graphql config #6630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/how/updating-datahub.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ This file documents any backwards-incompatible changes in DataHub and assists pe

### Breaking Changes

- `graphql_url` option of `powerbi-report-server` source deprecated as the options is not used.

### Potential Downtime

### Deprecations
Expand Down
2 changes: 0 additions & 2 deletions metadata-ingestion/docs/sources/powerbi/powerbi-report-server_recipe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ source:
server_alias: server_alias
# Workspace's dataset environments, example: (PROD, DEV, QA, STAGE)
env: DEV
# Workspace's dataset environments, example: (PROD, DEV, QA, STAGE)
graphql_url: http://localhost:8080/api/graphql
# Your Power BI Report Server base virtual directory name for reports
report_virtual_directory_name: Reports
# Your Power BI Report Server base virtual directory name for report server
Expand Down
6 changes: 4 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/powerbi_report_server/report_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#########################################################
import logging
from dataclasses import dataclass, field as dataclass_field
from typing import Any, Dict, Iterable, List
from typing import Any, Dict, Iterable, List, Optional

import pydantic
import requests
Expand Down Expand Up @@ -68,7 +68,9 @@ class PowerBiReportServerAPIConfig(EnvBasedSourceConfigBase):
server_alias: str = pydantic.Field(
default="", description="Alias for Power BI Report Server host URL"
)
graphql_url: str = pydantic.Field(description="GraphQL API URL")
graphql_url: Optional[str] = pydantic.Field(
default=None, description="[deprecated] Not used"
)
report_virtual_directory_name: str = pydantic.Field(
description="Report Virtual Directory URL name"
)
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/tests/integration/powerbi_report_server/test_powerbi_report_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def default_source_config():
"workstation_name": "workstation",
"host_port": "host_port",
"server_alias": "server_alias",
"graphql_url": "http://localhost:8080/api/graphql",
"graphql_url": None,
"report_virtual_directory_name": "Reports",
"report_server_virtual_directory_name": "ReportServer",
"env": "DEV",
Expand Down