Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quickstart): support for user-level sockets, arch option for forcing quickstart architecture #6279

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

shirshanka
Copy link
Contributor

@shirshanka shirshanka commented Oct 25, 2022

This PR fixes a couple of issues:

  • Docker desktop 4.13 introduces the preference of using user-level sockets, which make the docker python library fail on instantiating a docker client. Example issue where this is affecting other projects as well. We now look for the user-level socket if the default docker client instantiation fails. A longer term fix might be to remove our dependency on the docker python lib and use os.subprocess exclusively for all docker operations.
  • Detection of Apple silicon can be buggy if terminal emulation is enabled or the installed python is x86 based. We add a --arch option to allow the specification of architecture explicitly as a stop-gap measure while we improve our detection logic.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 25, 2022
@github-actions
Copy link

github-actions bot commented Oct 25, 2022

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 52s ⏱️ -5s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ±0 

Results for commit f793a93. ± Comparison against base commit 18df38e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   59m 0s ⏱️
   748 tests    745 ✔️ 3 💤 0
1 498 runs  1 492 ✔️ 6 💤 0

Results for commit f793a93.

@shirshanka shirshanka merged commit abf1b11 into datahub-project:master Oct 25, 2022
anthonyhungnguyen pushed a commit to anthonyhungnguyen/zlp-datahub that referenced this pull request Nov 8, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants