cleanup elastic setup just script

[davidspek]

The elasticsearch setup job fails currently as can be seen in this comment and likely caused by #5975 placing the insecure flag in a bad location. This PR changes the setup script so that the ${CURL_ARGS[@]} and $ELASTICSEARCH_URL variables are used everywhere fixing the problem from the aforementioned comment.

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[pedro93]

Hello @davidspek

Have you tried running the elastic search setup job from a more up-to-date image? We have recently fixed the reported bug here: #6079 which then got refactored here: #5502

Please use the head image tag and let us know whether this is still broken.

Thank you.

[davidspek]

@pedro93 I don't think I tried the head image, but regardless I think this cleanup is still valid since it ensures the defined variables are used everywhere.

[github-actions]

Unit Test Results (build & test)

0 tests   - 597   0 ✔️  - 593   0s ⏱️ - 11m 58s
0 suites  - 147   0 💤  -     4 
0 files    - 147   0 ❌ ±    0 

Results for commit 4d37d9a. ± Comparison against base commit 73fd358.