fix(frontend): refactoring AuthServiceClient #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Sep 22, 2022
|
|
||
| // TODO: Call getAuthenticatedUser and then generate a session cookie for the UI if the user is authenticated. | ||
|
|
||
| final Optional<String> maybeRedirectPath = Optional.ofNullable(ctx().request().getQueryString(AUTH_REDIRECT_URI_PARAM)); | ||
| final Optional<String> maybeRedirectPath = Optional.ofNullable(request.getQueryString(AUTH_REDIRECT_URI_PARAM)); |
jjoyce0510
reviewed
Sep 22, 2022
| .withHttpOnly(false) | ||
| .withMaxAge(Duration.of(30, ChronoUnit.DAYS)) | ||
| .build()); | ||
| return ok().withSession(createSessionMap(userUrnString, accessToken)) |
There was a problem hiding this comment.
Thanks for extracting the common logic!
jjoyce0510
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors AuthServiceClient to:
Checklist