Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add --no-pull-images option to docker quickstart #6017

Merged
merged 1 commit into from
Sep 22, 2022
Merged

feat(ingest): add --no-pull-images option to docker quickstart #6017

merged 1 commit into from
Sep 22, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 22, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 22, 2022
shirshanka
shirshanka approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 0m 58s ⏱️
   717 tests    714 ✔️ 3 💤 0 ❌
1 436 runs  1 430 ✔️ 6 💤 0 ❌

Results for commit b009a41.

@github-actions
Copy link

Unit Test Results (build & test)

562 tests  ±0   562 ✔️ ±0   12m 51s ⏱️ -1s
139 suites ±0       0 💤 ±0 
139 files   ±0       0 ❌ ±0 

Results for commit b009a41. ± Comparison against base commit 2ea9b67.

@shirshanka shirshanka merged commit 25b335d into datahub-project:master Sep 22, 2022
@hsheth2 hsheth2 deleted the docker-cli-skip-pull branch September 22, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka