fix(gms): Write back lineage search results to in-memory cache bound to feature flag #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
approved these changes
Sep 21, 2022
| if (lineageResult == null) { | ||
| maxHops = maxHops != null ? maxHops : 1000; | ||
| lineageResult = _graphService.getLineage(sourceUrn, direction, 0, MAX_RELATIONSHIPS, maxHops); | ||
| if (cacheEnabled) { | ||
| cache.put(Pair.of(sourceUrn, direction), lineageResult); |
There was a problem hiding this comment.
Could we drop in the current timestamp into the value section?
So maybe
cache.put(Pair.of(sourceUrn,direction), Pair.of(lineageResult, currentTimestamp))
that way we can always know when a cache entry was inserted into the cache, at least for debugging purposes.
| @@ -71,10 +73,14 @@ public LineageSearchResult searchAcrossLineage(@Nonnull Urn sourceUrn, @Nonnull | |||
| @Nonnull List<String> entities, @Nullable String input, @Nullable Integer maxHops, @Nullable Filter inputFilters, | |||
| @Nullable SortCriterion sortCriterion, int from, int size) { | |||
| // Cache multihop result for faster performance | |||
| EntityLineageResult lineageResult = cache.get(Pair.of(sourceUrn, direction), EntityLineageResult.class); | |||
| EntityLineageResult lineageResult = cacheEnabled ? cache.get(Pair.of(sourceUrn, direction), EntityLineageResult.class) | |||
There was a problem hiding this comment.
add a log.warn here if we found something in the cache and if the insert timestamp is from a long time ago (we can default to hard-coded 1 hour for this PR).
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist