Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reduce pip backtracking in airflow plugin #5982

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 19, 2022

This should make the build-and-test job fast again.

Also removes edge case handling for datahub-frontend unzipAssets, since this was fixed by #3452 and should not be an issue anymore.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Sep 19, 2022
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge once CI is the right amount of green :)

@github-actions
Copy link

Unit Test Results (build & test)

562 tests  +41   562 ✔️ +41   13m 18s ⏱️ - 1m 48s
139 suites +18       0 💤 ±  0 
139 files   +18       0 ±  0 

Results for commit d550a82. ± Comparison against base commit 98ee621.

This pull request removes 10 and adds 51 tests. Note that renamed tests count towards both.
datahub.spark.TestCoalesceJobLineage ‑ testHiveInHiveOutCoalesce
datahub.spark.TestSparkJobsLineage ‑ test1HdfsInOut
datahub.spark.TestSparkJobsLineage ‑ test2HdfsInHiveOut
datahub.spark.TestSparkJobsLineage ‑ test3HdfsJdbcInJdbcOut
datahub.spark.TestSparkJobsLineage ‑ test4HiveInHiveOut
datahub.spark.TestSparkJobsLineage ‑ test5HdfsInJdbcOut
datahub.spark.TestSparkJobsLineage ‑ test6HdfsJdbcInJdbcOutTwoLevel
datahub.spark.TestSparkJobsLineage ‑ test7HdfsInPersistHdfsOut
datahub.spark.TestSparkJobsLineage ‑ test8PersistHdfsJdbcInJdbcOut
datahub.spark.TestSparkJobsLineage ‑ test9PersistJdbcInHdfsOut
datahub.protobuf.ProtobufDatasetTest ‑ customFieldVisitors
datahub.protobuf.ProtobufDatasetTest ‑ duplicateNested
datahub.protobuf.ProtobufDatasetTest ‑ googleTimestamp
datahub.protobuf.ProtobufDatasetTest ‑ messageA
datahub.protobuf.ProtobufDatasetTest ‑ messageB
datahub.protobuf.ProtobufDatasetTest ‑ messageC
datahub.protobuf.ProtobufDatasetTest ‑ messageC2NestedOneOf
datahub.protobuf.ProtobufDatasetTest ‑ noSchemaTest
datahub.protobuf.ProtobufDatasetTest ‑ platformSchemaTest
datahub.protobuf.ProtobufUtilsTest ‑ registryTest
…

@hsheth2 hsheth2 merged commit 2f7fe59 into datahub-project:master Sep 19, 2022
@hsheth2 hsheth2 deleted the build-test-streamline branch September 19, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants