Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): pin great-expectations dependency to fix profiling error #5980

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

mayurinehate
Copy link
Collaborator

Issue raised on Slack

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 19, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   57m 47s ⏱️ -2s
   708 tests ±0     703 ✔️  - 2  3 💤 ±0  2 +2 
1 418 runs  ±0  1 410 ✔️  - 2  6 💤 ±0  2 +2 

For more details on these failures, see this check.

Results for commit e1b2e86. ± Comparison against base commit a407e0a.

@github-actions
Copy link

Unit Test Results (build & test)

520 tests   - 51   520 ✔️  - 51   16m 29s ⏱️ + 1m 22s
121 suites  - 20       0 💤 ±  0 
121 files    - 20       0 ±  0 

Results for commit e1b2e86. ± Comparison against base commit a407e0a.

This pull request removes 51 tests.
datahub.protobuf.ProtobufDatasetTest ‑ customFieldVisitors
datahub.protobuf.ProtobufDatasetTest ‑ duplicateNested
datahub.protobuf.ProtobufDatasetTest ‑ googleTimestamp
datahub.protobuf.ProtobufDatasetTest ‑ messageA
datahub.protobuf.ProtobufDatasetTest ‑ messageB
datahub.protobuf.ProtobufDatasetTest ‑ messageC
datahub.protobuf.ProtobufDatasetTest ‑ messageC2NestedOneOf
datahub.protobuf.ProtobufDatasetTest ‑ noSchemaTest
datahub.protobuf.ProtobufDatasetTest ‑ platformSchemaTest
datahub.protobuf.ProtobufUtilsTest ‑ registryTest
…

@shirshanka
Copy link
Contributor

@hsheth2 : looks like this pin creates problems for pip?

@hsheth2
Copy link
Collaborator

hsheth2 commented Sep 19, 2022

The build & test failure looks like the same issue that's causing the other builds to fail, while the ingestion test failure looks like a kafka test flake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants