Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): encode reserved characters when creating dataset urn #5977

Merged

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Sep 19, 2022

Closes #5918

This PR handles encoding of reserved characters for dataset URN alone. In future, this needs to be adopted across all URNs produced in the ingestion framework.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 19, 2022
@github-actions
Copy link

github-actions bot commented Sep 19, 2022

Unit Test Results (metadata ingestion)

       8 files  ±  0         8 suites  ±0   59m 54s ⏱️ +2s
   717 tests +  7     714 ✔️ +  7  3 💤 ±0  0 ±0 
1 436 runs  +14  1 430 ✔️ +14  6 💤 ±0  0 ±0 

Results for commit 3e202fe. ± Comparison against base commit 46494bc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 19, 2022

Unit Test Results (build & test)

562 tests  ±0   562 ✔️ ±0   12m 56s ⏱️ -29s
139 suites ±0       0 💤 ±0 
139 files   ±0       0 ±0 

Results for commit 3e202fe. ± Comparison against base commit 46494bc.

♻️ This comment has been updated with latest results.

@hsheth2 hsheth2 merged commit b195b6c into datahub-project:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tableau Ingestion : Failed to convert urn to entity key: urns parts and key fields do not have same length
2 participants