Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Make LookML deploy key a textarea and format key #5946

Merged

Conversation

chriscollins3456
Copy link
Collaborator

Secrets do not work with ssh keys right now. Instead, let's allow them to paste the key in this text area to set on the recipe. I auto add a new line for them to format properly.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 14, 2022
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me..

@github-actions
Copy link

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   14m 57s ⏱️ +13s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ±0 

Results for commit 9358b31. ± Comparison against base commit cf2f59f.

@jjoyce0510 jjoyce0510 merged commit a3af510 into datahub-project:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants