fix(ui) Filter search through schemas based on non-editable tags and terms as well #5942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Sep 15, 2022
| if ( | ||
| matchesFieldName(row.fieldPath, formattedFilterText) || | ||
| matchesEditableTagsOrTerms(row, filteredFieldPathsByEditableMetadata) || | ||
| tagsOrTermsMatchFilter(row, formattedFilterText, entityRegistry) // non-editable tags and terms |
There was a problem hiding this comment.
Should this be matchesTagsOrTerms?
There was a problem hiding this comment.
certainly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only filtering schemas by matching on editable tags and terms. This adds an additional check to see if we match non-editable tags and terms on the fields themselves. This involved a little refactoring of my check matching methods.
Checklist