refactor(gms): Refactoring util + entity client class locations #5902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscollins3456
approved these changes
Sep 12, 2022
Comment on lines
+690
to
+708
| // Creates new Filter from a map of Criteria by removing null-valued Criteria and using EQUAL condition (default). | ||
| @Nonnull | ||
| public static Filter newFilter(@Nullable Map<String, String> params) { | ||
| if (params == null) { | ||
| return new Filter().setOr(new ConjunctiveCriterionArray()); | ||
| } | ||
| CriterionArray criteria = params.entrySet() | ||
| .stream() | ||
| .filter(e -> Objects.nonNull(e.getValue())) | ||
| .map(e -> newCriterion(e.getKey(), e.getValue(), Condition.EQUAL)) | ||
| .collect(Collectors.toCollection(CriterionArray::new)); | ||
| return new Filter().setOr( | ||
| new ConjunctiveCriterionArray(ImmutableList.of(new ConjunctiveCriterion().setAnd(criteria)))); | ||
| } | ||
|
|
||
| @Nonnull | ||
| public static Criterion newCriterion(@Nonnull String field, @Nonnull String value, @Nonnull Condition condition) { | ||
| return new Criterion().setField(field).setValue(value).setCondition(condition); | ||
| } |
There was a problem hiding this comment.
just curios - why duplicate these from QueryUtils to here?
There was a problem hiding this comment.
Query Utils are unfortunately inside of metadata-io which should be a library that is NOT exposed to folks who just want to use a RestliEntityClient... It's too heavy. So we've removed this dependency completely and as part of that we had to duplicate this shared logic. That being said, I think it'd be better moving forward to establish a module where truly "shared" libraries can reside. I'm going to add a TODO here
shirshanka
pushed a commit
to RyanHolstien/datahub
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor refactoring PR to move location of JavaEntityClient and various util methods / classes into more suitable locations.
Checklist