Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small UI bugs #5886

Merged
merged 5 commits into from
Sep 20, 2022
Merged

Small UI bugs #5886

merged 5 commits into from
Sep 20, 2022

Conversation

Ankit-Keshari-Vituity
Copy link
Contributor

  • Added comma to number
  • Rename the terms title to Glossary terms in Schema Tab

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 9, 2022 •
edited
Loading

Unit Test Results (build & test)

562 tests  ±0   562 ✔️ ±0   12m 50s ⏱️ -15s
139 suites ±0       0 💤 ±0 
139 files   ±0       0 ❌ ±0 

Results for commit 04f2f2d. ± Comparison against base commit 6232447.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 reviewed Sep 9, 2022
View reviewed changes
datahub-web-react/src/app/shared/numberWithCommas.tsx Outdated
@@ -0,0 +1,4 @@
// Function to convert a number with comma
export const numberWithCommas = (number) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this. We already have a "formatNumber" method that we use everywhere else! Please just reuse that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted numberWithCommas function and used formatNumber to format number.

@anshbansal anshbansal added the product PR or Issue related to the DataHub UI/UX label Sep 12, 2022
@chriscollins3456 chriscollins3456 merged commit a432f49 into datahub-project:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ankit-Keshari-Vituity @jjoyce0510 @chriscollins3456 @anshbansal