Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ingest): use pytest parameterization for dbt integration tests #5879

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 8, 2022

Changes stacked on #5877.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 29s ⏱️
   691 tests    688 ✔️ 3 💤 0
1 382 runs  1 376 ✔️ 6 💤 0

Results for commit d659b3d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   14m 15s ⏱️ -58s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ±0 

Results for commit d659b3d. ± Comparison against base commit afa5888.

♻️ This comment has been updated with latest results.

@hsheth2 hsheth2 added the ingestion PR or Issue related to the ingestion of metadata label Sep 9, 2022
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 3cd8ea8 into datahub-project:master Sep 11, 2022
@hsheth2 hsheth2 deleted the dbt-refactor-tests branch September 12, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants