feat(docs) Adds guide on how to use personal access tokens #5873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szalai1
reviewed
Sep 9, 2022
There was a problem hiding this comment.
@pedro93 static assets should go to https://github.com/datahub-project/static-assets
AFAIK
aditya-radhakrishnan
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
LGTM! @jjoyce0510 can you confirm whether static assets should stay in the imgs directory or be moved to the other repo?
maggiehays
requested changes
Sep 14, 2022
There was a problem hiding this comment.
@pedro93 This is an AWESOME improvement to the existing guide - much easier to follow and approable. Left a couple of comments, but otherwise this is 🔥
|
|
||
| 1. Click `Generate new token` where a form should appear. | ||
|
|
||
|  |
There was a problem hiding this comment.
Couple of nit-picks for consistency with other guides & improved readability:
- images should be stored in https://github.com/datahub-project/static-assets
- please use HTML to embed images so we can size down (70%) & center-align:
<p align="center">
<img width="70%" src="https://raw.githubusercontent.com/datahub-project/static-assets/master/imgs/token-creation-form.png"/>
</p>
|
Comments addressed, this PR depends on https://github.com/datahub-project/static-assets/pull/8/files being merged. |
pedro93
force-pushed
the
personal-token-guide
branch
from
59ff596 to
2a84006
Compare
maggiehays
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist