Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ingest): move aspect maps to dedicated file #5821

Merged
merged 3 commits into from
Sep 11, 2022
Merged

refactor(ingest): move aspect maps to dedicated file #5821

merged 3 commits into from
Sep 11, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 2, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   55m 9s ⏱️
   671 tests    668 ✔️ 3 💤 0 ❌
1 342 runs  1 336 ✔️ 6 💤 0 ❌

Results for commit 932b182.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   8m 21s ⏱️ - 1m 11s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit 932b182. ± Comparison against base commit 5d61924.

@anshbansal anshbansal added the ingestion PR or Issue related to the ingestion of metadata label Sep 8, 2022
anshbansal
anshbansal approved these changes Sep 10, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anshbansal
anshbansal reviewed Sep 10, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw there are file conflicts. So should probably resolve them on local.

shirshanka
shirshanka approved these changes Sep 11, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 8f72de5 into datahub-project:master Sep 11, 2022
@hsheth2 hsheth2 deleted the refactor-aspect-classes branch December 15, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @shirshanka @anshbansal