-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion): schema inference for jsonlines in S3 #5725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results (build & test)521 tests - 50 515 ✔️ - 56 14m 10s ⏱️ - 1m 32s For more details on these failures, see this check. Results for commit 2f6284d. ± Comparison against base commit e556bcb. This pull request removes 50 tests.
♻️ This comment has been updated with latest results. |
duyet
suggested changes
Aug 27, 2022
hsheth2
requested changes
Aug 30, 2022
metadata-ingestion/src/datahub/ingestion/source/schema_inference/json.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/schema_inference/json.py
Outdated
Show resolved
Hide resolved
hsheth2
reviewed
Sep 8, 2022
metadata-ingestion/src/datahub/ingestion/source/schema_inference/json.py
Outdated
Show resolved
Hide resolved
hsheth2
approved these changes
Sep 9, 2022
@hieunt-itfoss looks like there's a small linting error |
shirshanka
pushed a commit
to RyanHolstien/datahub
that referenced
this pull request
Sep 12, 2022
…t#5725) Co-authored-by: Nguyen Tri Hieu <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
ingestion
PR or Issue related to the ingestion of metadata
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5603
Checklist