Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ingest): drop data-lake source in favor of s3 source #5628

Merged
merged 4 commits into from
Aug 16, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 11, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Aug 11, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 16m 57s ⏱️ + 2m 59s
   645 tests  - 1     643 ✔️ +3  2 💤 ±0  0 ±0 
1 290 runs   - 2  1 286 ✔️ +2  4 💤 ±0  0 ±0 

Results for commit 23d292b. ± Comparison against base commit a449e8b.

This pull request removes 1 test.
tests.integration.data_lake.test_data_lake ‑ test_data_lake_ingest

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 11, 2022

Unit Test Results (build & test)

499 tests  ±0   493 ✔️  - 6   8m 14s ⏱️ -28s
115 suites ±0       0 💤 ±0 
115 files   ±0       6 +6 

For more details on these failures, see this check.

Results for commit 772b43c. ± Comparison against base commit e9494f5.

♻️ This comment has been updated with latest results.

@maggiehays maggiehays added the ingestion PR or Issue related to the ingestion of metadata label Aug 12, 2022
@hsheth2 hsheth2 marked this pull request as ready for review August 16, 2022 04:39
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 680c4a8 into datahub-project:master Aug 16, 2022
@hsheth2 hsheth2 deleted the drop-data-lake-source branch December 15, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants