Schema tab: Fixed the header issue

[Ankit-Keshari-Vituity]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[github-actions]

Unit Test Results (build & test)

499 tests  ±0   499 ✔️ ±0   8m 25s ⏱️ -17s
115 suites ±0       0 💤 ±0 
115 files   ±0       0 ❌ ±0 

Results for commit 21ba722. ± Comparison against base commit e9494f5.

[chriscollins3456]

Good stuff!

[chriscollins3456]

it might be better to have this be height: 100%; but after checking locally I don't believe it really matters in this situation

[jjoyce0510]

Doesn't this mean that we are forcing schema tab height to the height of the browser window?

[chriscollins3456]

that is indeed what it's saying, but in this case it doesn't make a difference since this div can never grow higher than its parent. So in theory it's working the same as height: 100% but only in this situation. If there was no parent or if this was absolutely positioned it would fill the whole content and be the view height of the browser window.

All that being said I think here we actually just change it to be 100% instead of 100vh even though functionally there the same here (just better css practice)