Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): use default telemetry ID when config is unwritable #5614

Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 10, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from shirshanka August 10, 2022 20:07
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 15m 40s ⏱️ + 2m 29s
   645 tests ±0     642 ✔️ ±0    3 💤 ±0  0 ±0 
1 228 runs  ±0  1 178 ✔️ ±0  50 💤 ±0  0 ±0 

Results for commit 502129e. ± Comparison against base commit 34c2f94.

@github-actions
Copy link

Unit Test Results (build & test)

499 tests  ±0   499 ✔️ ±0   9m 32s ⏱️ + 1m 4s
115 suites ±0       0 💤 ±0 
115 files   ±0       0 ±0 

Results for commit 502129e. ± Comparison against base commit 34c2f94.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 44328b6 into datahub-project:master Aug 10, 2022
@hsheth2 hsheth2 deleted the telemetry-static-id-when-missing branch December 15, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants