Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): use graphql instead of restli #5610

Merged
merged 4 commits into from
Aug 16, 2022
Merged

fix(ci): use graphql instead of restli #5610

merged 4 commits into from
Aug 16, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal added the devops PR or Issue related to DataHub backend & deployment label Aug 10, 2022
@github-actions
Copy link

github-actions bot commented Aug 10, 2022 •
edited
Loading

Unit Test Results (build & test)

499 tests  ±0   499 ✔️ ±0   8m 40s ⏱️ -15s
115 suites ±0       0 💤 ±0 
115 files   ±0       0 ❌ ±0 

Results for commit f5ec418. ± Comparison against base commit 626196d.

♻️ This comment has been updated with latest results.

hsheth2
hsheth2 reviewed Aug 10, 2022
View reviewed changes
smoke-test/tests/read_only/test_search.py

restli_default_headers = {
"X-RestLi-Protocol-Version": "2.0.0",
}

ENTITY_TO_MAP = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a programmatic way to populate this mapping?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as far as I am aware

@anshbansal anshbansal requested a review from treff7es August 16, 2022 06:43
treff7es
treff7es approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@anshbansal anshbansal merged commit 01e5bdf into datahub-project:master Aug 16, 2022
@anshbansal anshbansal deleted the aseem-smoke-test-debug branch August 16, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @treff7es @hsheth2