feat(search) Allow users to update the number of search results per page #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
approved these changes
Jun 24, 2022
alexey-kravtsov
pushed a commit
to infobip/datahub
that referenced
this pull request
Jul 8, 2022
…age (datahub-project#5212) Co-authored-by: Chris Collins <[email protected]>
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…age (datahub-project#5212) Co-authored-by: Chris Collins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were hardcoding the number of search results per page to be 10. Now it's dynamic and leverages Ant designs existing component to allow users to set how many results they want to see per page.
Here's what it looks like:
Checklist