Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): remove need for sink block in UI based ingestion #5208

Merged
merged 8 commits into from
Jun 23, 2022
Merged

feat(ingest): remove need for sink block in UI based ingestion #5208

merged 8 commits into from
Jun 23, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 18m 19s ⏱️ - 2m 59s
   576 tests ±0     573 ✔️ ±0    3 💤 ±0  0 ❌ ±0 
1 090 runs  ±0  1 047 ✔️ ±0  43 💤 ±0  0 ❌ ±0 

Results for commit 9505b4b. ± Comparison against base commit 8c8f1b9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

Unit Test Results (build & test)

389 tests  +4   389 ✔️ +4   11m 13s ⏱️ +20s
  92 suites +1       0 💤 ±0 
  92 files   +1       0 ❌ ±0 

Results for commit 9505b4b. ± Comparison against base commit 8c8f1b9.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal assigned jjoyce0510 and unassigned treff7es Jun 21, 2022
jjoyce0510
jjoyce0510 reviewed Jun 22, 2022
View reviewed changes
metadata-ingestion/src/datahub/cli/cli_utils.py
@@ -170,6 +172,14 @@ def guess_entity_type(urn: str) -> str:
return urn.split(":")[2]


def get_system_auth() -> Optional[str]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

jjoyce0510
jjoyce0510 reviewed Jun 22, 2022
View reviewed changes
metadata-ingestion/src/datahub/emitter/rest_emitter.py
@@ -91,6 +74,10 @@ def __init__(
)
if token:
self._session.headers.update({"Authorization": f"Bearer {token}"})
else:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome solve! Thanks aseem.

treff7es
treff7es approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anshbansal anshbansal merged commit 1adcc99 into datahub-project:master Jun 23, 2022
@anshbansal anshbansal deleted the use-system-secret-ingest branch June 23, 2022 09:52
alexey-kravtsov pushed a commit to infobip/datahub that referenced this pull request Jul 8, 2022
@anshbansal @alexey-kravtsov
feat(ingest): remove need for sink block in UI based ingestion (datah…
ec982fa 
…ub-project#5208)
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
feat(ingest): remove need for sink block in UI based ingestion (datah…
aeebe60 
…ub-project#5208)
@hsheth2 hsheth2 mentioned this pull request Jul 26, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@treff7es treff7es treff7es approved these changes

Assignees

@jjoyce0510 jjoyce0510

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @treff7es @jjoyce0510