Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): dbt - adding support for dbt tests #5201

Merged
merged 1 commit into from
Jun 18, 2022

Conversation

shirshanka
Copy link
Contributor

@shirshanka shirshanka commented Jun 18, 2022

This PR adds support for dbt tests.

  • Support for test definitions is enabled by default.
  • Support for test run results is enabled by providing access to test results (run_results.json) through a new configuration flag
  • Some of the common tests have been mapped to standard datahub assertions
  • Unmapped tests are still viewable and results will be viewable
  • Contributors are encouraged to add more mappings in the future to standard test types

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

382 tests  ±0   382 ✔️ ±0   8m 54s ⏱️ -32s
  89 suites ±0       0 💤 ±0 
  89 files   ±0       0 ±0 

Results for commit 2c865dc. ± Comparison against base commit e2f1da00.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       6 files         6 suites   1h 14m 30s ⏱️
   557 tests    553 ✔️   3 💤 1
1 994 runs  1 921 ✔️ 72 💤 1

For more details on these failures, see this check.

Results for commit 2c865dc.

Copy link
Contributor

@swaroopjagadish swaroopjagadish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 0ee2569 into datahub-project:master Jun 18, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants