Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump Nimbus Jose JWT dependency #5158

Merged
merged 1 commit into from
Jun 14, 2022
Merged

chore(deps): Bump Nimbus Jose JWT dependency #5158

merged 1 commit into from
Jun 14, 2022

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Jun 14, 2022

Attempts to fix CVE-2019-17195 which comes from com.nimbusds:nimbus-jose-jwt dependency transitively from Pac4J. Fix is to exclude jar and include a specific version.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

381 tests  ±0   381 ✔️ ±0   2m 52s ⏱️ -11s
  89 suites ±0       0 💤 ±0 
  89 files   ±0       0 ❌ ±0 

Results for commit 7998a0f. ± Comparison against base commit 38718b5.

RyanHolstien
RyanHolstien approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swaroopjagadish swaroopjagadish merged commit 66b9676 into datahub-project:master Jun 14, 2022
@pedro93 pedro93 deleted the pedro/bump-jose-jwt-dep branch June 14, 2022 17:37
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@pedro93 @maggiehays
chore(deps): Bump Nimbus Jose JWT dependency (datahub-project#5158)
6b749b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@swaroopjagadish swaroopjagadish swaroopjagadish approved these changes

@shirshanka shirshanka Awaiting requested review from shirshanka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedro93 @RyanHolstien @swaroopjagadish