feat(dbt): Platform instances for target platform #5129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e607410.
gabe-lyons
reviewed
Jun 9, 2022
| @@ -456,11 +462,27 @@ def get_custom_properties(node: DBTNode) -> Dict[str, str]: | |||
| return custom_properties | |||
|
|
|||
|
|
|||
| def match_target_platform_instance( | |||
There was a problem hiding this comment.
lets call this get_entity_platform_instance, since it may be getting a platform instance for a dbt node and not a target node
gabe-lyons
reviewed
Jun 9, 2022
| self.config.platform_instance, | ||
| match_target_platform_instance( | ||
| self.config.target_platform_instance, | ||
| None, |
There was a problem hiding this comment.
why set this as none here? let's let the logic of the method handle whether to use the dbt platform instance or not. that will make things less error prone
There was a problem hiding this comment.
Ok I added reference to config platform_instance here. Originally here there was a None if I recall correctly and I wanted to preserve the original logic, so that in case platform would match dbt it would still return None as before. But if you think we should return platform instance I adjusted it to return platform instance.
shirshanka
approved these changes
Jun 12, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 configuration fields
target_platform_instanceandtarget_platform_instance_mappingto allow for setting target platform instance values.Checklist