Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): ingest - moving packaging to framework_common #5096

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be merged once CI passes

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Unit Test Results (build & test)

334 tests  ±0   334 ✔️ ±0   3m 29s ⏱️ +6s
  78 suites ±0       0 💤 ±0 
  78 files   ±0       0 ±0 

Results for commit cd8c82e. ± Comparison against base commit 3c7c83f.

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   1h 32m 5s ⏱️ - 7m 25s
   555 tests ±0     552 ✔️ ±0    3 💤 ±0  0 ±0 
2 552 runs  ±0  2 477 ✔️ ±0  75 💤 ±0  0 ±0 

Results for commit cd8c82e. ± Comparison against base commit 3c7c83f.

♻️ This comment has been updated with latest results.

@jjoyce0510 jjoyce0510 merged commit 7cef074 into datahub-project:master Jun 6, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants