Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): suggest upgrades when appropriate #5091

Merged
merged 4 commits into from
Jun 4, 2022
Merged

feat(cli): suggest upgrades when appropriate #5091

merged 4 commits into from
Jun 4, 2022

Conversation

shirshanka
Copy link
Contributor

  • Checks client server compatibility
  • Encourages cli upgrades to latest
  • Encourages quickstart upgrades to latest

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 4, 2022 •
edited
Loading

Unit Test Results (build & test)

334 tests  ±0   334 ✔️ ±0   2m 51s ⏱️ -18s
  78 suites ±0       0 💤 ±0 
  78 files   ±0       0 ❌ ±0 

Results for commit 22ae5e8. ± Comparison against base commit ce149ae.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

Unit Test Results (metadata ingestion)

       4 files         4 suites   1h 1m 28s ⏱️
   532 tests    520 ✔️   2 💤 0 ❌ 10 🔥
1 954 runs  1 843 ✔️ 71 💤 0 ❌ 40 🔥

For more details on these errors, see this check.

Results for commit bef8fc9.

treff7es
treff7es approved these changes Jun 4, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shirshanka shirshanka merged commit e62c647 into datahub-project:master Jun 4, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@shirshanka @maggiehays
feat(cli): suggest upgrades when appropriate (datahub-project#5091)
c0ce5a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @treff7es