Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model): new chart types #5017

Merged
merged 3 commits into from
Jun 1, 2022
Merged

feat(model): new chart types #5017

merged 3 commits into from
Jun 1, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal
Copy link
Collaborator Author

@gabe-lyons Please change title when merging. Not sure what the correct one would be for this thing.

@github-actions
Copy link

github-actions bot commented May 26, 2022 •
edited
Loading

Unit Test Results (build & test)

  77 files  ±0    77 suites  ±0   2m 44s ⏱️ +14s
333 tests ±0  333 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e1a1a09. ± Comparison against base commit d6239f8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 26, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files         5 suites   1h 25m 47s ⏱️
   551 tests    548 ✔️   3 💤 0 ❌
2 532 runs  2 459 ✔️ 73 💤 0 ❌

Results for commit e1a1a09.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal assigned treff7es and unassigned gabe-lyons Jun 1, 2022
treff7es
treff7es approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anshbansal anshbansal merged commit 2dd8266 into datahub-project:master Jun 1, 2022
@anshbansal anshbansal deleted the new-chart-types branch June 1, 2022 12:44
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
feat(model): new chart types (datahub-project#5017)
5fc634a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees

@treff7es treff7es

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @treff7es @gabe-lyons