Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest) dbt: Dbt query tag mapping and match template #4744

Merged
merged 6 commits into from
Apr 25, 2022

Conversation

treff7es
Copy link
Contributor

Adding option to set tags with query tags
Adding {{ match }} template to be able to reference dbt mapping keys.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Adding ${{ match }} template to reference the matched key in a metamapping
@github-actions
Copy link

github-actions bot commented Apr 25, 2022

Unit Test Results (build & test)

  97 files  ±0    97 suites  ±0   18m 8s ⏱️ - 3m 6s
701 tests ±0  642 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit a4e474c. ± Comparison against base commit a518e3d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 25, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   49m 33s ⏱️ - 14m 44s
   434 tests ±0     427 ✔️  - 7    0 💤 ±0  2 +2  5 🔥 +5 
2 095 runs  ±0  2 042 ✔️  - 7  46 💤 ±0  2 +2  5 🔥 +5 

For more details on these failures and errors, see this check.

Results for commit a4e474c. ± Comparison against base commit a518e3d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CI failures seem unrelated.

@shirshanka shirshanka merged commit 474b0ba into datahub-project:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants