Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(timelineCli): fix naming for timeline cli (#4729)" #4731

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

jjoyce0510
Copy link
Collaborator

This reverts commit 7bcc2d9 due to server-compatibility concerns.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Unit Test Results (build & test)

  97 files  ±0    97 suites  ±0   16m 38s ⏱️ - 2m 13s
701 tests ±0  642 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 7728eea. ± Comparison against base commit 40cb83f.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   57m 40s ⏱️
   433 tests    433 ✔️   0 💤 0
2 090 runs  2 044 ✔️ 46 💤 0

Results for commit 7728eea.

@shirshanka shirshanka merged commit b1b1898 into datahub-project:master Apr 22, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants