feat(ml): show custom properties for MLFeatureTable in UI #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
approved these changes
Apr 20, 2022
gabe-lyons
reviewed
Apr 20, 2022
| @@ -41,6 +42,8 @@ public MLFeatureTableProperties apply(@NonNull final com.linkedin.ml.metadata.ML | |||
| .collect(Collectors.toList())); | |||
| } | |||
|
|
|||
| result.setCustomProperties(StringMapMapper.map(mlFeatureTableProperties.getCustomProperties())); | |||
There was a problem hiding this comment.
@maaaikoool I think we need a (if mlFeatureTableProperties. getCustomProperties() != null) check here
There was a problem hiding this comment.
I believe that customProperties is non nullable ( it has a @Nonnull annotation )
There was a problem hiding this comment.
There was a problem hiding this comment.
I've double checked with other mappers and it seems that indeed we are using a conditional assignment checking for hasCustomProperties so I've added it for consistency 👌
|
thanks for the review! |
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…oject#4706) * feat(ml): show custom properties for MLFeatureTable in UI * Make assignment conditional * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the properties tab to MLFeatureTable, which is quite handy to add custom metadata that does not fit with the actual model.
Checklist