-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingestion): validate datasource in Tableau connector, before creating its upstream #4613
fix(ingestion): validate datasource in Tableau connector, before creating its upstream #4613
Conversation
…ting its upstream
Unit Test Results (metadata ingestion) 5 files ± 0 5 suites ±0 54m 59s ⏱️ + 33m 20s For more details on these errors, see this check. Results for commit c99dba0. ± Comparison against base commit 5637e73. ♻️ This comment has been updated with latest results. |
@mayurinehate please take a look |
Hey, thanks for raising the PR. I would like to suggest a change in the PR - to fix the cause of this error at its source. |
* Check before appending to datasource_for_csql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…tream (datahub-project#4613) Co-authored-by: Tamas Nemeth <[email protected]>
Checklist
Hi!
We are using Datahub Tableau connector and we are facing an issue when ingesting some Tableau data sources, as shown below:
This is happening because
datasource
isNone
and this PR adds a validation that fix this issue.For the ingestion, we were testing with the following Datahub versions:
0.8.31
and0.8.32
.Thank you!