Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kafka-connect): add platform for default case in jdbc connector, … #4545

Merged
merged 1 commit into from
Mar 31, 2022
Merged

fix(kafka-connect): add platform for default case in jdbc connector, … #4545

merged 1 commit into from
Mar 31, 2022

Conversation

mayurinehate
Copy link
Collaborator

…update tests for platform instance map

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  96 files  ±0    96 suites  ±0   18m 58s ⏱️ + 2m 42s
686 tests ±0  627 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 981a582. ± Comparison against base commit a10a4ac.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   1h 3m 46s ⏱️ + 6m 24s
   392 tests ±0     392 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 804 runs  ±0  1 773 ✔️ ±0  31 💤 ±0  0 ❌ ±0 

Results for commit 981a582. ± Comparison against base commit a10a4ac.

shirshanka
shirshanka approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit c09834d into datahub-project:master Mar 31, 2022
@mayurinehate mayurinehate deleted the fix_kafka_connect_platform_instance branch April 6, 2022 08:33
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@mayurinehate @maggiehays
fix(kafka-connect): add platform for default case in jdbc connector, …
9588eee 
…update tests for platform instance map (datahub-project#4545)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @shirshanka