Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protobuf) Additional protobuf features #4493

Merged
merged 8 commits into from
Mar 30, 2022
Merged

feat(protobuf) Additional protobuf features #4493

merged 8 commits into from
Mar 30, 2022

Conversation

leifker
Copy link
Contributor

@leifker leifker commented Mar 24, 2022 •
edited
Loading

  • Domains
  • Ownership
  • Tags from comma delimited strings
  • Custom properties lists
  • Additional documentation

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 24, 2022 •
edited
Loading

Unit Test Results (build & test)

  96 files    96 suites   14m 35s ⏱️
686 tests 627 ✔️ 59 💤 0 ❌

Results for commit 7e7b234.

♻️ This comment has been updated with latest results.

@leifker leifker force-pushed the leifker/protobuf_improvements branch from b9627e7 to 85cf4f7 Compare March 25, 2022 11:19
@leifker leifker force-pushed the leifker/protobuf_improvements branch 3 times, most recently from a2480f8 to 965964c Compare March 30, 2022 15:51
@leifker
feat(protobuf) Additional protobuf ingestion features
7e7b234 
* Domains
* Ownership
* Tags from comma delimited strings
* Custom property lists
* Additional documentation
* Fix nested duplicate types
@leifker leifker force-pushed the leifker/protobuf_improvements branch from 965964c to 7e7b234 Compare March 30, 2022 15:52
shirshanka
shirshanka approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 9cc6d8a into datahub-project:master Mar 30, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@leifker @maggiehays
feat(integration): protobuf - additional annotations and features (da…
c9cc6c3 
…tahub-project#4493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees

@shirshanka shirshanka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leifker @shirshanka