bug(cli): handle case insensitive entity types for cli delete #4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Mar 24, 2022
| or entity_type == "dataflow" | ||
| or entity_type == "datajob" | ||
| or entity_type == "container" | ||
| and entity_type_lower == "dataset" |
There was a problem hiding this comment.
Is there anywhere else we do these types of entity type comparisons in the CLI?
There was a problem hiding this comment.
There are a few others, but they look to be already using .lower() or are in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Delete CLI does not handle case sensitivity for DataFlow & DataJob #4461