Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): extract redshift platform correctly from sqlalchemy uri #4421

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix(ingest): extract redshift platform correctly from sqlalchemy uri #4421

merged 2 commits into from
Mar 16, 2022

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   19m 41s ⏱️ + 3m 32s
673 tests ±0  614 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 7b347c2. ± Comparison against base commit 2d10d99.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   47m 52s ⏱️ - 1m 8s
   362 tests ±0     362 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 657 runs  ±0  1 626 ✔️ +7  31 💤  - 7  0 ❌ ±0 

Results for commit 7b347c2. ± Comparison against base commit 2d10d99.

♻️ This comment has been updated with latest results.

treff7es
treff7es approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 9025bfb into datahub-project:master Mar 16, 2022
jjoyce0510
jjoyce0510 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

jjoyce0510
jjoyce0510 reviewed Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this.

@mayurinehate mayurinehate deleted the fix_redshift_sqlalchemy branch April 6, 2022 08:34
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@mayurinehate @maggiehays
fix(ingest): extract redshift platform correctly from sqlalchemy uri (d…
b2c8858 
…atahub-project#4421)

* fix(ingest): extract redshift platform from sqlalchemy uri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayurinehate @treff7es @jjoyce0510