Refactoring the quries into a single one to get the search results on Home Page #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Mar 11, 2022
| }); | ||
| const searchResultsToShow = useMemo(() => { | ||
| let result: string[] | undefined = []; | ||
| if (!searchResultsLoading) { |
There was a problem hiding this comment.
We can also just say...
if (searchResultsData) {
....
}
There was a problem hiding this comment.
This will also simplify the dependencies required for the useMemo
There was a problem hiding this comment.
Fixed and Commited
jjoyce0510
reviewed
Mar 11, 2022
| @@ -232,11 +206,11 @@ export const HomePageHeader = () => { | |||
| autoCompleteStyle={styles.searchBox} | |||
| entityRegistry={entityRegistry} | |||
| /> | |||
| {suggestionsToShow && suggestionsToShow.length > 0 && ( | |||
| {searchResultsToShow && searchResultsToShow.length > 0 && ( | |||
There was a problem hiding this comment.
minor: we can simplify to
searchResultsToShow?.length > 0
There was a problem hiding this comment.
As We are using
let result: string[] | undefined = [];
That's why added check searchResultsToShow && searchResultsToShow.length > 0.
shirshanka
approved these changes
Mar 15, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist