feat(*): Support setting owner type when assigning ownership #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set-ownership-type-from-ui
jjoyce0510
changed the title
…set-ownership-type-from-ui
…set-ownership-type-from-ui
shirshanka
approved these changes
Mar 14, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for setting the following new "owner types" or "roles" when assigning an owner to an asset (dataset, chart, job, dashboard, etc):
Along with a fallback "None" type which indicates that no particular role type should be assigned.
As part of this, will be deprecating "official" support for previous OwnershipType enum symbols, including
In favor of a simpler, clearer, more concise set of owner types. This means that we will gradually migrate ingestion sources to using the new types. Additionally, any new ownership created via the UI will be restricted to one of the new types, however display will continue to work for legacy types that already exist in the Metadata Model. There will be no functional problems with continuing to leverage the old Ownership Types, for the foreseeable future.
More details to come with release v0.8.29.
Status
Working to update some smoke tests to provide Ownership type.
Screenshots
Checklist