Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): revert positional arg change #4266

Merged

Conversation

anshbansal
Copy link
Collaborator

Change done in #4189 can be a breaking change for people using the client. Reverting the change.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Feb 28, 2022

Unit Test Results (build & test)

  71 files  ±0    71 suites  ±0   10m 20s ⏱️ - 10m 20s
618 tests ±0  559 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit b720f09. ± Comparison against base commit bcabff8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 28, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   48m 24s ⏱️
   343 tests    343 ✔️   0 💤 0
1 562 runs  1 531 ✔️ 31 💤 0

Results for commit b720f09.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit d52638a into datahub-project:master Mar 2, 2022
@anshbansal anshbansal deleted the revert_breaking_change branch March 2, 2022 09:07
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants