-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): Schema version history timeline. #4252
Merged
shirshanka
merged 45 commits into
datahub-project:master
from
rslanka:schema_version_history_oss
Feb 25, 2022
Merged
feat(platform): Schema version history timeline. #4252
shirshanka
merged 45 commits into
datahub-project:master
from
rslanka:schema_version_history_oss
Feb 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding new classes for computing timeline add json patch lib add initial controller fix test reformat code improve test timeline command v1 detect double encoding add start and end initial docs & fix endpoint move to openapi split openapi to different servlet fix docs showing up issue Implements SchemaDiffer for ordinal based schemas. Update tests WIP: Don't checkin non-ordinal based impl. Implements diffing logic for non-ordinal based schemas in the SchemaDiffer. unwinding settings change fix element id add logic to convert strings to enum Primary key constraint change events. Added logic for assigning computed semantic version to transactions. add apis to frontend dropdown Minor refactoring, renaming/rearranging of fields. add exceptional logic to schemadiffer and example files Move transaction id out of ChangeTransaction. Fix NPE if both base and target fields have no description. obey rawdiffrequested, update how jsonpatch appears as schema in swagger, remove mock service, update CLI Generate EXCEPTIONAL change events when schema are not compatible. Revert the RESTLI based implementaion: "Schema Version Change APIs + basic differ implementation." This reverts commit def13e5528701fffa2510ed5ee792323a65f850b. tags based differ should be basicdiffer small fixes and improvements fixing lint Use V1 style field paths in the description Fix issue with version field in v1 fieldPath conversion logic. fix test to not assert :( adding colored output Fix mypy issue with termcolor. remove unused files rename element Use urns to populate elementId & target. Replace DatasetFieldUrns with schemaField urns. improve rendering final fix
shirshanka
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the schema version history feature.
Checklist