fix(ingest) Athena: db filter was not applied #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rslanka
reviewed
Feb 11, 2022
| @@ -33,10 +33,22 @@ def get_sql_alchemy_url(self): | |||
|
|
|||
|
|
|||
| class AthenaSource(SQLAlchemySource): | |||
| config: AthenaConfig | |||
There was a problem hiding this comment.
Delete this. The config is already an instance member of SQLAlchemySource, and will get correctly initialized via lines 44->39.
treff7es
changed the title
rslanka
reviewed
Feb 11, 2022
| def __init__(self, config, ctx): | ||
| super().__init__(config, ctx, "athena") | ||
|
|
||
| @classmethod | ||
| def create(cls, config_dict, ctx): | ||
| config = AthenaConfig.parse_obj(config_dict) | ||
| return cls(config, ctx) | ||
|
|
||
| # It seems like database/schema filter in the connection string does not work and this to work around that | ||
| def get_schema_names(self, inspector): |
There was a problem hiding this comment.
missing return type annotation.
rslanka
reviewed
Feb 11, 2022
| def get_schema_names(self, inspector): | ||
| schemas = inspector.get_schema_names() | ||
| if self.config.database: | ||
| for schema in schemas: |
There was a problem hiding this comment.
50-53
return [schema in schemas if schema == self.config.database]
shirshanka
approved these changes
Feb 11, 2022
ne1r0n
pushed a commit
to ne1r0n/datahub
that referenced
this pull request
Feb 13, 2022
* Fix for db filter on Athena * Black formatting * Addressing pr comments * Remove unneeded imports
hevandro-veiga
pushed a commit
to hevandro-veiga/datahub
that referenced
this pull request
Feb 18, 2022
* Fix for db filter on Athena * Black formatting * Addressing pr comments * Remove unneeded imports
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
* Fix for db filter on Athena * Black formatting * Addressing pr comments * Remove unneeded imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist