-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Host platform images on datahub-web-react #4118
feat(ui): Host platform images on datahub-web-react #4118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ngamanda, thoughts on just doing this for everyone? I think most (if not all) of folks would prefer hosting their own platform logos, and the additional cost should be pretty small. Any reason not to automatically do this?
Hi @gabe-lyons ! I thought to leave it as optional. But yes, I'd think most users would also prefer to host their own assets. I've updated the PR with the changes :) |
datahub-web-react/craco.config.js
Outdated
webpack: { | ||
plugins: { | ||
add: [ | ||
new CopyWebpackPlugin({ | ||
patterns: [{ from: 'src/images', to: 'platforms' }], | ||
}), | ||
], | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just add an explanation for why the copy is needed? otherwise looks great!! thanks @ngamanda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
Unit Test Results (metadata ingestion) 3 files ± 0 3 suites ±0 41m 22s ⏱️ - 1m 40s Results for commit bedc690. ± Comparison against base commit 9bdc9af. This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…4118) * feat(react-images): host platform images on datahub-web-react * feat(react-images): update data_platforms logoUrl * feat(react-images): add explanation for CopyWebpackPlugin Co-authored-by: Amanda Ng <[email protected]>
…4118) * feat(react-images): host platform images on datahub-web-react * feat(react-images): update data_platforms logoUrl * feat(react-images): add explanation for CopyWebpackPlugin Co-authored-by: Amanda Ng <[email protected]>
Adds capability for users to host their platform images (from
src/images
) on their react app instead.Context: https://datahubspace.slack.com/archives/CV2UXSE9L/p1644477881072309
Changes
src/images
toplatforms
data_platforms.json
files are updated to use the new relative urlSample Usage:
Checklist