Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): datahub-gms - build in native, copy to target #3992

Merged
merged 2 commits into from
Jan 27, 2022
Merged

fix(docker): datahub-gms - build in native, copy to target #3992

merged 2 commits into from
Jan 27, 2022

Conversation

swaroopjagadish
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

shirshanka
shirshanka approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since docker datahub-gms seems green!

@shirshanka shirshanka merged commit 4b7f2b7 into datahub-project:master Jan 27, 2022
@github-actions
Copy link

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   16m 8s ⏱️ + 6m 4s
505 tests +5  449 ✔️ +6  56 💤 ±0  0 ❌  - 1 
505 runs  +4  449 ✔️ +6  56 💤 ±0  0 ❌  - 2 

Results for commit e2e9f82. ± Comparison against base commit eac3c62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swaroopjagadish @shirshanka